New plugins by listepo · Pull Request #10 · listepo/cross-code

listepo · 2026-08-08T20:21:15Z

Summary by CodeRabbit

Chores
- Updated project configuration to improve build, development, preview, and type-checking workflows.
- Improved handling of generated configuration files and build-related tooling.
- Refined workspace setup for more consistent development environments.
Bug Fixes
- No user-facing defects were addressed in this update.
User Impact
- No visible changes to application features or behavior.

coderabbitai · 2026-08-08T20:21:46Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5942c1c5-f8cc-4f3e-9275-32551b473324

📥 Commits

Reviewing files that changed from the base of the PR and between d6d9749 and 2d062da.

📒 Files selected for processing (2)

.gitignore
nx.json

🚧 Files skipped from review as they are similar to previous changes (2)

.gitignore
nx.json

📝 Walkthrough

Walkthrough

The pull request adds Nx and Vite development tooling, configures Vite targets in Nx, updates production inputs and release commands, and adjusts workspace build permissions and generated-file ignores.

Changes

Tooling configuration

Layer / File(s)	Summary
Package and workspace tooling `package.json`, `pnpm-workspace.yaml`, `.gitignore`	The project adds Nx/Vite development packages and an empty root `dependencies` object. pnpm disables build scripts for `unrs-resolver`. Git ignores timestamped Vite configuration files.
Nx and Vite integration `nx.json`	Nx adds Vite target mappings, excludes test setup files from production inputs, uses `pnpm exec` for release builds, and compacts existing target configuration.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately identifies the main change: adding and configuring new Nx and Vite plugins.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch new-plugins

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 2

🧹 Nitpick comments (1)

nx.json (1)
46-50: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Remove the deprecated serve target unless compatibility requires it.

Nx documents serveTargetName as deprecated and devTargetName as its replacement. The two names represent the same Vite development-server capability. (nx.dev)

Remove serveTargetName unless existing scripts or projects still require nx serve.
Suggested configuration
                 "devTargetName": "dev",
-                "serveTargetName": "serve",
                 "previewTargetName": "preview",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@nx.json` around lines 46 - 50, Remove the deprecated serveTargetName entry
from the Nx configuration, while retaining devTargetName as the
development-server target. Preserve serveTargetName only if repository scripts
or projects explicitly depend on nx serve.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@nx.json`:
- Line 60: Update the preVersionCommand release hook in nx.json to invoke Nx
through the repository-pinned pnpm executable, replacing the npx command with
pnpm exec nx while preserving the existing run-many build arguments.

In `@packages/ns-wamr/package.json`:
- Around line 158-159: Update the typings.ios and typings.android scripts in
package.json to execute their respective ns typings commands from the
apps/ns-wasm-test working directory, so generated declarations are written to
that app’s typings directory.

---

Nitpick comments:
In `@nx.json`:
- Around line 46-50: Remove the deprecated serveTargetName entry from the Nx
configuration, while retaining devTargetName as the development-server target.
Preserve serveTargetName only if repository scripts or projects explicitly
depend on nx serve.

🪄 Autofix

✅ Autofix completed

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 94995fd9-0c17-4fed-8215-abffeff53652

📥 Commits

Reviewing files that changed from the base of the PR and between dfc3acc and d6d9749.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (5)

.gitignore
nx.json
package.json
packages/ns-wamr/package.json
pnpm-workspace.yaml

coderabbitai · 2026-08-08T20:44:14Z

Fixes Applied Successfully

Fixed 2 file(s) based on 2 unresolved review comments.

Files modified:

nx.json
packages/ns-wamr/package.json

Commit: d16ad8647fc7a62a1d12eb74ce615d196c4811a5

The changes have been pushed to the new-plugins branch.

Time taken: 2m 18s

Fixed 2 file(s) based on 2 unresolved review comments. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>

listepo added 2 commits August 8, 2026 23:20

feat(nx): add @nx/vite plugin and web tooling deps

9452555

chore(ns-wamr): simplify typings scripts

d6d9749

coderabbitai Bot reviewed Aug 8, 2026

View reviewed changes

Comment thread nx.json Outdated

Comment thread packages/ns-wamr/package.json Outdated

coderabbitai Bot and others added 2 commits August 8, 2026 20:47

fix: apply CodeRabbit auto-fixes

d16ad86

Fixed 2 file(s) based on 2 unresolved review comments. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>

chore: ignore CodeGraph index directory

2d062da

Navigation Menu

New plugins - #10

New plugins#10
listepo wants to merge 4 commits into
mainfrom
new-plugins

listepo commented Aug 8, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 8, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 8, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

listepo commented Aug 8, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixes Applied Successfully

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

listepo commented Aug 8, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 8, 2026 •

edited

Loading

coderabbitai Bot left a comment •

edited

Loading

coderabbitai Bot commented Aug 8, 2026 •

edited

Loading